Fix ConstantArrayType::hasOffsetValueType and ArrayType::hasOffsetValueType #4387
+104
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
fix/HasOffsetValueType
branch
2 times, most recently
from
60f6325 to
adc7fa0
Compare
VincentLanglet
changed the title
VincentLanglet
force-pushed
the
fix/HasOffsetValueType
branch
from
adc7fa0 to
bd0382b
Compare
VincentLanglet
changed the title
|
This pull request has been marked as ready for review. |
VincentLanglet
force-pushed
the
fix/HasOffsetValueType
branch
from
bd0382b to
cdaa47f
Compare
|
Thank you. |
|
Thanks, I rebased #4385 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #4385
When you merge this PR, I would recommend to wait for #4385 too in order to avoid reporting extra "duplicate" message "offset might not exist"/"offset does not exist" since we're detecting more errors with this fix.
I prefer to test hasOffsetValueType rather with errors reported by NonexistentOffsetInArrayDimFetchRule since